Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stops komponent components from being listed in the style guide sidebar #167

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GeoffTidey
Copy link

@GeoffTidey GeoffTidey commented Jul 30, 2020

  • Updated README to include help on gem installation for appraisal tests
  • Created komponent fixture components for path tests
  • Added filter to remove any path that starts with ‘komponent/ from Komponent::Component.all

closes #164

- Create komponent fixture components for path tests
- Add filter to remove anything path that starts with ‘komponent/ from  Komponent::Component.all
@Spone
Copy link
Collaborator

Spone commented Oct 7, 2020

Hi @GeoffTidey I don't see any change to the tests in your PR diff.

Can you confirm that you just needed to add the komponent/* components to the fixture app in order to test that they were not counted here?

@GeoffTidey
Copy link
Author

Hey @Spone, it's been a while since I made this PR, but I have a recollection adding the komponent components to the fixtures was required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Files from frontend/components/komponent listed in styleguide sidebar
2 participants