Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preview version names in release process. #108

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

ZvonimirMatic
Copy link
Contributor

In release action, remove 'v' only from the beginning of the version. Currently it's removing all letters 'v' from the version so v4.0.0-preview.2 is published as 4.0.0-preiew.2.

Found the solution using Chat GPT and this StackOverflow post: https://stackoverflow.com/questions/71630227/github-action-how-to-remove-starting-v-from-variable

Can't really test it, hopefully it works.

Closes #106.

@koenbeuk koenbeuk merged commit 005784e into koenbeuk:master Jun 12, 2024
4 checks passed
@rmunn
Copy link

rmunn commented Jun 13, 2024

Variable substitution in Bash is documented here. The # syntax deletes the shortest matching pattern from the beginning of the variable (and ## deletes the longest matching pattern instead). Here there's only one pattern (v) and it's one character long, so the shortest/longest distinction shouldn't matter. So yes, based on my knowledge of Bash syntax, this looks correct to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NuGet packages named "preiew" instead of "preview"
3 participants