Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pet in Terra repo guide #318

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Add pet in Terra repo guide #318

merged 3 commits into from
Oct 10, 2024

Conversation

Owen-sz
Copy link
Contributor

@Owen-sz Owen-sz commented Oct 4, 2024

Description of changes:

I recently packaged pet into the Terra repository, a 3rd party repository for Fedora/Fedora based distributions, so I have added this to your README.

I also added Fedora in the RPM download guide, along with RedHat/CentOS, as I feel it should be there.

Link to package PR: terrapkg/packages#2127

Owen-sz and others added 3 commits October 3, 2024 15:48
Add pet in Terra repo
Add Fedora to RPM install section
Lowercase r
@RamiAwar
Copy link
Collaborator

RamiAwar commented Oct 10, 2024

Hey @Owen-sz, thank you so much for doing this! This will make a lot of users happy 🙂 🥳 🎊

Just to triple check, even though I did some research, the package will for sure be built from the Github source right? Doesn't expose it to people uploading their own binaries in the future or specifying custom source code.

Well I guess if the source on that terra repo changed to a custom repo in the future then it might be dangerous, but that's on the terra maintainers to ensure the right repo is used right?

Just trying to make sure we don't encourage something unsafe in our readme.

@RamiAwar RamiAwar merged commit 56b43be into knqyf263:main Oct 10, 2024
2 checks passed
@Owen-sz
Copy link
Contributor Author

Owen-sz commented Oct 11, 2024

Well I guess if the source on that terra repo changed to a custom repo in the future then it might be dangerous, but that's on the terra maintainers to ensure the right repo is used right

You're welcome! And yes, your assumptions are correct. I am a part of the project that maintains Terra, and we have a maintainer personally review each pull request, so changing the repo, and by extent a malicious change, should never get merged.

@RamiAwar
Copy link
Collaborator

Amazing, thank you! And thanks for the PR again 🙂 @Owen-sz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants