Multi file, multi folder support #121
Conversation
|
Thank you for the awesome contribution! Let me know why you removed config.go. Also, it would be appreciated if you show an example to use this new feature. |
|
Thanks and sorry for the late reply.
I will add a section to the readme as soon as possible. |
|
@knqyf263 I've added the Readme section. I would very much like your feedback. |
|
There's a typo in the readme change. |
|
I'm so sorry to be too late. I'm reviewing this PR. |
There was a problem hiding this comment.
Could you revert config.go? If we don't have it, we have to access each value with a string like viper.GetString("gitlab.file_name") everywhere as you did. This is likely to cause typos and is not desirable for completion. If you strongly hope it, let's open the dedicated issue and discuss it.
| .PHONY: \ | ||
| all \ | ||
| dep \ | ||
| depup \ | ||
| update \ | ||
| build \ | ||
| install \ | ||
| lint \ | ||
| vet \ | ||
| fmt \ | ||
| fmtcheck \ | ||
| clean \ | ||
| pretest \ | ||
| test |
There was a problem hiding this comment.
Is there any reason to remove them?
| ) | ||
|
|
||
| // clipCmd represents the clip command | ||
| var clipCmd = &cobra.Command{ |
There was a problem hiding this comment.
This feature is not related to multi-folder support, right? If so, could you open another PR for this feature?
| ) | ||
|
|
||
| // completionCmd represents the completion command | ||
| var completionCmd = &cobra.Command{ |
|
@knqyf263 it was my bad to open this PR from master branch. I'll try to cleanup this PR to only include multi-folder and multi-file support. |
|
Hi everyone. Thank you for this great project! Is there any timeline on when this PR will be merged? I'm using @helmecke fork for now. |
Issue #47 , if available:
Description of changes:
Added support for multiple files in multiple folders.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.