fix: Fixed bug with multiple default values, added hint

README.md

@@ -35,6 +35,7 @@ So I made it possible to register snippets with description and search them easi
 # TOC
 
 - [Main features](#main-features)
+- [Parameters] (#parameters)
 - [Examples](#examples)
   - [Register the previous command easily](#register-the-previous-command-easily)
     - [bash](#bash-prev-function)

dialog/params_test.go

@@ -211,6 +211,21 @@ func TestSearchForParams_EqualsInDefaultValueIgnored(t *testing.T) {
 	}
 }
 
+func TestSearchForParams_MultipleDefaultValuesDoNotBreakFunction(t *testing.T) {
+	command := "echo \"<param=|_Hello_||_Hello world_||_How are you?_|> <second=Hello>, <third>\""
+	want := [][2]string{
+		{"param", "|_Hello_||_Hello world_||_How are you?_|"},
+		{"second", "Hello"},
+		{"third", ""},
+	}
+
+	got := SearchForParams(command)
+
+	if diff := deep.Equal(want, got); diff != nil {
+		t.Fatal(diff)
+	}
+}
+
 func TestInsertParams(t *testing.T) {
 	command := "<a=1> <a> <b> hello"
 

dialog/view.go

@@ -82,9 +82,16 @@ func generateMultipleParameterView(g *gocui.Gui, desc string, defaultParams []st
 
 		fmt.Fprint(v, defaultParams[currentOpt])
 	}
-
+	
 	view, _ := g.View(desc)
-	view.Title = desc
+	viewTitle := desc
+	// Adjust view title to hint the user about the available 
+	// options if there are more than one
+	if maxOpt > 1 {
+		viewTitle = desc + " (UP/DOWN => Select default value)"
+	}
+
+	view.Title = viewTitle
 	view.Wrap = false
 	view.Autoscroll = true
 	view.Editable = editable
@@ -117,12 +124,14 @@ func GenerateParamsLayout(params [][2]string, command string) {
 	// Create a view for each param
 	for _, pair := range params {
 		// Unpack parameter key and value
-		k, v := pair[0], pair[1]
+		parameterKey, parameterValue := pair[0], pair[1]
 
-		// Handle multiple default values
+		// Check value for multiple defaults
 		r := regexp.MustCompile(parameterMultipleValueRegex)
-		matches := r.FindAllStringSubmatch(command, -1)
+		matches := r.FindAllStringSubmatch(parameterValue, -1)
+
 		if len(matches) > 0 {
+			// Extract the default values and generate multiple params view
 			parameters := []string{}
 			for _, p := range matches {
 				_, matchedGroup := p[0], p[1]
@@ -131,14 +140,17 @@ func GenerateParamsLayout(params [][2]string, command string) {
 				parameters = append(parameters, matchedGroup)
 			}
 			generateMultipleParameterView(
-				g, k, parameters, []int{leftX,
+				g, parameterKey, parameters, []int{
+					leftX,
 					(maxY / 4) + (idx+1)*layoutStep,
 					rightX,
 					(maxY / 4) + 2 + (idx+1)*layoutStep},
 				true)
 		} else {
-			generateSingleParameterView(g, k, v,
-				[]int{leftX,
+			// Generate single param view using the single value
+			generateSingleParameterView(g, parameterKey, parameterValue,
+				[]int{
+					leftX,
 					(maxY / 4) + (idx+1)*layoutStep,
 					rightX,
 					(maxY / 4) + 2 + (idx+1)*layoutStep},