[FEATURE] Implement MIME type filtering for files in Helper class #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fschoelzel
commented
Sep 18, 2024
fschoelzel
commented
- switched from simple mime-type list to provided MimeTypeCollection list from TYPO3 Core
- add filter method to helper class
- custom key and category Parameter
- add filter for images in ToolboxController and PageViewController
- prevent download of files which are in mets:fileGrp USE="DEFAULT"
There was a problem hiding this comment.
While this is great for the image download tool, will this still work for IIIF and IIP images? Those won't have an image/* MIME type, but something like application/*. The changes in PageView controller suggest that those images won't be displayed any more... Or am I missing something?
fschoelzel
force-pushed
the
helper-mimetype-filter
branch
2 times, most recently
from
33d0a78
to
4a61aea
Compare
- switched from simple mime-type list to provided MimeTypeCollection list from TYPO3 Core - add filter method to helper class - custom key and category Parameter - add filter for images in ToolboxController and PageViewController - prevent download of files which are in mets:fileGrp USE="DEFAULT"
fschoelzel
force-pushed
the
helper-mimetype-filter
branch
from
640f6a5
to
1e8fd27
Compare
|
I simplified the |
sebastian-meyer
approved these changes
Oct 21, 2024
sebastian-meyer
modified the milestones:
Kitodo.Presentation 5.1.0,
Kitodo.Presentation 6.0.0
sebastian-meyer
pushed a commit
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.