This repository has been archived by the owner on Jan 30, 2023. It is now read-only.
export in dec_time or std_time in export_pdf2 #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -102,7 +102,16 @@ public function printRows($data, $widths) { | |||
| else { | |||
| $this->printTimeRow($widths, $row); | |||
| $this->moneySum += $row['wage']; | |||
| $this->timeSum += $row['decimalDuration'] == -1 ? 0 : $row['decimalDuration']; | |||
| if ($_REQUEST['time_type'] == "dec_time") { | |||
There was a problem hiding this comment.
It looks as if there are race-conditions where timeSum will not be generated.
I would prefer creating a default timeSum (leaving the previous line) and then overwriting its value in case $_REQUEST['time_type'] != 'dec_time' && isset($this->columns['time'])
There was a problem hiding this comment.
on line 105 if $_REQUEST['time_type'] != 'dec_time then it goes to line 109 } else {
and there, if isset($this->columns['time'] TimeSum is updated
I don't understand your race-condition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES #
Changes proposed in this pull request:
Reason for this pull request: