-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shape analysis #58
Draft
lucaspena
wants to merge
133
commits into
master
Choose a base branch
from
shape-analysis
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Shape analysis #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What's the plan for this PR? It looks too big to be merged given its current status. |
Yes, we're putting it here so that the CI runs the tests. We're going to break this apart into multiple PRs later (the subst PR is one of them) |
lucaspena
force-pushed
the
shape-analysis
branch
3 times, most recently
from
April 23, 2020 21:29
98e7f3b
to
b8bc773
Compare
… the smoke tests however)
This fixes issues in the various drivers. This logically makes more sense since it is the strategy cell that controls the execution.
…ng rule not to fire
…rectly instead of substPatternsMap
…tially to avoid confusion
…clause and any other clause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OOPSLA (new kt-collapse rule, shape analysis rules, abstracting nil, etc.)