Fix out-of-tree building #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"add_subdirectory(third_party)" should be in CMakeLists.example.txt (and already in CMakeLists.txt) I think your issue is about miss-synchronize between |
|
Ok, I found it's ok to write this here, reopen this, please wait for review. |
GongT
reviewed
Aug 8, 2019
| @@ -10,6 +10,7 @@ if (NOT BUILDING_SDK) | |||
| ### source code sdk | |||
| include_directories(${SDK_ROOT}/lib/arch/include ${SDK_ROOT}/lib/utils/include) | |||
| add_subdirectory(${SDK_ROOT}/lib SDK) | |||
| add_subdirectory(${SDK_ROOT}/third_party THIRD_PARTY) | |||
|
I had the same issue. It would be cool to merge this (after fixing indentation). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for the patch provided in issue #30. In tree building still appears to work fine with this change, so I can only assume it doesn't have any side effects.
Out of tree project building failed because the third_party libraries within the sdk weren't included in the sdks cmake files.