Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exp to engine.Value #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add exp to engine.Value #10

wants to merge 1 commit into from

Conversation

ritesh99rakesh
Copy link

I have added exp function using math.exp in micrograd/engine.py

I will add tests once the changes are approved.

@karpathy, please review

@wangcongcong123
Copy link

There is pow method. Why still needs this method? Just curious.

@karpathy
Copy link
Owner

because pow currently requires the second argument to be an int/float.

@dhern023
Copy link

dhern023 commented Jun 9, 2024

I will add tests once the changes are approved.

No one would /should approve untested code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants