Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tools): add basic makefile, to prevent confusion on how to setup tests #21

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

itsdevbear
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.92%. Comparing base (e314ffd) to head (55e03c6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   83.92%   83.92%           
=======================================
  Files          61       61           
  Lines        3035     3035           
=======================================
  Hits         2547     2547           
  Misses        323      323           
  Partials      165      165           
Components Coverage Δ
ssz 83.24% <ø> (ø)
sszgen 70.99% <ø> (ø)

@karalabe
Copy link
Owner

Wondering whether it would be better to just have a section about it in the readme. For example the tests repo relies on git LFS, which the user would need to install/enable separately. I'd guess that's not possible to outsmart with a Makefile, in which case we're only partially covering the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants