Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternate Get retry approach to avoid copy-and-paste #81

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Alternate Get retry approach to avoid copy-and-paste #81

merged 1 commit into from
Oct 13, 2023

Conversation

sseago
Copy link

@sseago sseago commented Oct 13, 2023

Possible retry.go refactor to avoid more copy-and-paste

@vercel
Copy link

vercel bot commented Oct 13, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @kaovilai on Vercel.

@kaovilai first needs to authorize it.

@netlify
Copy link

netlify bot commented Oct 13, 2023 •
edited
Loading

✅ Deploy Preview for velero-k canceled.

Name Link
🔨 Latest commit deff165
🔍 Latest deploy log https://app.netlify.com/sites/velero-k/deploys/652979fadab3ca00087c11bc

kaovilai
kaovilai approved these changes Oct 13, 2023
View reviewed changes
Copy link
Owner

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. Will do some minor cleanup after merge.

@kaovilai kaovilai merged commit 181156f into kaovilai:createAlreadyExistsGetRetry Oct 13, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaovilai kaovilai kaovilai approved these changes

Assignees

@sseago sseago

Labels
has-unit-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sseago @kaovilai