fix(FEC-13878): copy the hls.worker.js file #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lianbenjamin
requested review from
JonathanTGold,
SivanA-Kaltura,
MosheMaorKaltura and
semarche-kaltura
SivanA-Kaltura
requested changes
May 21, 2024
JonathanTGold
suggested changes
May 21, 2024
MosheMaorKaltura
approved these changes
May 21, 2024
lianbenjamin
added a commit
to kaltura/playkit-js-hls
that referenced
this pull request
May 21, 2024
### Description of the Changes **the issue:** hls worker is not working. **solution:** remove configuration that disabled the worker. **related PR:** kaltura/kaltura-player-js#776 #### Resolves FEC-13878
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
the issue:
for source only entries which we don't know where are the keyframes (i.e. zoom integration), the playback get stuck after making seek several times to different positions in the playback.
solution:
after investigating the issue, seems to only be an hlsjs issue, where hls is reducing the max buffer length to a value that is lower than the fragment duration.
when setting hls
enableWorkerconfiguration totrue, the issue cannot be reproduced anymore.at some point we disabled the worker since it stopped working and generated an error to the console (see relevant PR here); in the current solution we make the worker work again by resolving the original issue of hls worker & webpak.
related PR: kaltura/playkit-js-hls#218
Resolves FEC-13878