Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(playback_speed): playbackSpeed guide #587

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

giladna
Copy link
Contributor

@giladna giladna commented Oct 27, 2022

Description of the Changes

Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated


```
customLabels: {
//qualities: translateVideoQuality,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you leave this in, explain what it's used for


#### Example:

**[Tracks Lables configuration](https://codepen.io/giladna/pen/WNyexqO)**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check how to replace with github pages

docs/tracks-labels-configuration.md Outdated Show resolved Hide resolved
docs/tracks-labels-configuration.md Show resolved Hide resolved
docs/tracks-labels-configuration.md Outdated Show resolved Hide resolved
docs/tracks-labels-configuration.md Outdated Show resolved Hide resolved

#### Example:

**[Playback Speed Example](https://codepen.io/giladna/pen/Poawvre)**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment about Github Pages

docs/playback-speed.md Outdated Show resolved Hide resolved
docs/playback-speed.md Outdated Show resolved Hide resolved
docs/playback-speed.md Outdated Show resolved Hide resolved
giladna and others added 14 commits November 3, 2022 15:34
Co-authored-by: Sivan Agranov <88330203+SivanA-Kaltura@users.noreply.github.com>
Co-authored-by: Sivan Agranov <88330203+SivanA-Kaltura@users.noreply.github.com>
Co-authored-by: Sivan Agranov <88330203+SivanA-Kaltura@users.noreply.github.com>
Co-authored-by: Sivan Agranov <88330203+SivanA-Kaltura@users.noreply.github.com>
Co-authored-by: Sivan Agranov <88330203+SivanA-Kaltura@users.noreply.github.com>
Co-authored-by: Sivan Agranov <88330203+SivanA-Kaltura@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants