Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend current ImageConfig to allow more values to images as well as … #505

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Mar 13, 2023

What this PR does:
Part of the implementation of k8ssandra/k8ssandra-operator#532

Which issue(s) this PR fixes:
Fixes k8ssandra/k8ssandra-operator#532
Fixes #636

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@burmanm burmanm requested a review from a team as a code owner March 13, 2023 14:46
@burmanm
Copy link
Contributor Author

burmanm commented Mar 13, 2023

PR still missing modifications to ImagePullPolicy for certain imageTypes in the CassandraDatacenter spec..

burmanm and others added 5 commits October 11, 2024 10:40
…additional configuration options for each image type

Add modified PullPolicy to containers

Add ability to restrict pullSecrets added per pod

Make internal imageConfig to be non-pointer to allow easier usage in tests

Make some pointer accesses safer
apis/config/v1beta1/imageconfig_types.go Show resolved Hide resolved
@@ -35,11 +34,17 @@ type ImageConfig struct {

DefaultImages *DefaultImages `json:"defaults,omitempty"`

ImagePolicy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: is this missing json:",inline"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it doesn't make any difference in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for image namespace override K8SSAND-1476 ⁃ Revisit default values for images.Image struct
2 participants