Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump remark-lint-no-dead-urls from 1.1.0 to 2.0.0 #329

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 30, 2024

Bumps remark-lint-no-dead-urls from 1.1.0 to 2.0.0.

Release notes

Sourced from remark-lint-no-dead-urls's releases.

2.0.0

Change

  • fcd9e43 Change to require Node.js 18 migrate: update Node
  • 8d91f5f Change to use exports migrate: don’t use private APIs
  • e6489d4 Change to use ESM, TypeScript migrate: use import by @​ChristianMurphy in remarkjs/remark-lint-no-dead-urls#44
  • 56b572a fb8292c Replace check-links w/ dead-or-alive migrate: replace gotOptions -> deadOrAliveOptions; notably change options.gotOptions.prefixUrl to options.from
  • 51ecab8 Change to improve messages

Fix

  • 68d24e1 Fix handling of skipLocalhost option

Miscellaneous

  • 388e7f7 Add declaration maps
  • 20691f8 Refactor to move main types to index.d.ts
  • 426f596 1c8905d Refactor code-style
  • b819084 a9ced5d Refactor docs

Full Changelog: remarkjs/remark-lint-no-dead-urls@v1.1.0...2.0.0

Commits
Maintainer changes

This version was pushed to npm by wooorm, a new releaser for remark-lint-no-dead-urls since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [remark-lint-no-dead-urls](https://github.com/remarkjs/remark-lint-no-dead-urls) from 1.1.0 to 2.0.0.
- [Release notes](https://github.com/remarkjs/remark-lint-no-dead-urls/releases)
- [Commits](remarkjs/remark-lint-no-dead-urls@v1.1.0...2.0.0)

---
updated-dependencies:
- dependency-name: remark-lint-no-dead-urls
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 30, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola
Copy link
Member

@brandond This bump has introduced a bunch of irrelevant and frankly bad warnings about external url redirects, so I am changing this plugin to only produce a warning, not fail test builds.

For example, it considers all URL redirects effictively "Bad" even when such redirects make sense:

47:96-47:157    warning Unexpected redirecting URL `https://github.com/k3s-io/k3s/releases/latest`, 
expected final URL `https://github.com/k3s-io/k3s/releases/tag/v1.31.1+k3s1`       

Additionally, valid anchors are now also tagged as dead:

282:5-282:134   warning Unexpected dead URL `https://github.com/kubernetes/enhancements/blob/master/keps/sig-auth/279-limit-node-access/README.md#proposal`, 
expected live URL                                                                          no-dead-urls remark-lint
  [cause]:
    Unexpected missing anchor element on `https://github.com/kubernetes/enhancements/blob/master/keps/sig-auth/279-limit-node-access/README.md` 
    for fragment `proposal`, remove if unneeded or refer to an existing element

@brandond
Copy link
Member

brandond commented Oct 2, 2024

It looks like we can disable the anchor checking with an option - technically it's correct since the anchor isn't in the page, it's in an iframe on that page and they have some javascript that makes it work in the iframe. It is still dumb though.

I don't see an option to make it not complain that you should link directly to the redirect target.

@brandond
Copy link
Member

brandond commented Oct 2, 2024

Should we just pin to the old version?

@dereknola dereknola merged commit dff9a72 into main Oct 14, 2024
4 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/remark-lint-no-dead-urls-2.0.0 branch October 14, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants