fix: Do not lowercase dimension inputs while resolving #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushjain17
force-pushed
the
noLowerCase
branch
from
8bf4b84
to
b8dea5b
Compare
ayushjain17
force-pushed
the
noLowerCase
branch
from
b8dea5b
to
f65a178
Compare
ayushjain17
changed the title
mahatoankitkumar
approved these changes
Apr 26, 2024
ShubhranshuSanjeev
approved these changes
Apr 26, 2024
Datron
pushed a commit
that referenced
this pull request
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Resolve screen converts all the values of dimensions to lower case
Solution
Do not lowercase dimension inputs while resolving