fix: fixed duplicate snowflake id gen and busy wait on snowflake_gene…

…rator mutex

crates/context_aware_config/src/api/context/handlers.rs

@@ -51,10 +51,10 @@ use service_utils::{bad_argument, result as superposition};
 pub fn endpoints() -> Scope {
     Scope::new("")
         .service(put_handler)
-        .service(move_handler)
-        .service(delete_context)
         .service(bulk_operations)
         .service(list_contexts)
+        .service(move_handler)
+        .service(delete_context)
         .service(get_context)
 }
 

crates/experimentation_platform/src/api/experiments/handlers.rs

@@ -161,6 +161,8 @@ async fn create(
     // generating snowflake id for experiment
     let mut snowflake_generator = state.snowflake_generator.lock().unwrap();
     let experiment_id = snowflake_generator.real_time_generate();
+    // explicitly dropping snowflake_generator so that lock is released and it can be acquired in bulk-operations handler
+    drop(snowflake_generator);
 
     //create overrides in CAC, if successfull then create experiment in DB
     let mut cac_operations: Vec<ContextAction> = vec![];

crates/service_utils/src/service/types.rs

@@ -7,6 +7,7 @@ use std::{
     collections::HashSet,
     future::{ready, Ready},
     str::FromStr,
+    sync::Arc,
 };
 
 use actix_web::{error, web::Data, Error, FromRequest, HttpMessage};
@@ -37,7 +38,7 @@ pub struct AppState {
     pub default_config_validation_schema: JSONSchema,
     pub meta_schema: JSONSchema,
     pub experimentation_flags: ExperimentationFlags,
-    pub snowflake_generator: Mutex<SnowflakeIdGenerator>,
+    pub snowflake_generator: Arc<Mutex<SnowflakeIdGenerator>>,
     pub enable_tenant_and_scope: bool,
     pub tenant_middleware_exclusion_list: HashSet<String>,
     pub service_prefix: String,

crates/superposition/src/main.rs

@@ -7,6 +7,7 @@ use context_aware_config::helpers::{
 };
 use dotenv;
 use experimentation_platform::api::*;
+use std::sync::Arc;
 use std::{collections::HashSet, io::Result};
 use superposition_types::User;
 
@@ -134,6 +135,8 @@ async fn main() -> Result<()> {
         return view! { <App app_envs=routes_ui_envs.clone()/> };
     });
 
+    let snowflake_generator = Arc::new(Mutex::new(SnowflakeIdGenerator::new(1, 1)));
+
     HttpServer::new(move || {
         let leptos_options = &conf.leptos_options;
         let site_root = &leptos_options.site_root;
@@ -161,7 +164,7 @@ async fn main() -> Result<()> {
                         allow_same_keys_non_overlapping_ctx.to_owned(),
                 },
 
-                snowflake_generator: Mutex::new(SnowflakeIdGenerator::new(1,1)),
+                snowflake_generator: snowflake_generator.clone(),
                 meta_schema: get_meta_schema(),
                 app_env: app_env.to_owned(),
                 enable_tenant_and_scope: enable_tenant_and_scope.to_owned(),