feat: added setup for payment method management widget #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25harsh
reviewed
Oct 18, 2024
hyperswitchSDK/Core/HyperPaymentMethodManagement/PaymentMethodManagement.swift
Outdated
Show resolved
Hide resolved
| public func presentPaymentManagementSheet(viewController: UIViewController, configuration: PMMConfiguration, completion: @escaping (PaymentMethodManagementSheetResult) -> ()) { | ||
| let pmManagement = PaymentMethodManagement(ephemeralKey: PaymentSession.ephemeralKey ?? "", configuration: configuration) | ||
| pmManagement.presentPaymentMethodManagementView(from: viewController, completion: completion) | ||
| public func getPaymentMethodManagementWidget(frame: CGRect, onAddPaymentMethod: (() -> Void)?, completion: @escaping (PaymentMethodManagementResult) -> ()) -> UIControl { |
There was a problem hiding this comment.
incorrect approach don't use a function to get widget, use widget UIView Directly
There was a problem hiding this comment.
but that would become asymetric to how we consume the paymentSheet. If that's ok then this is just a wrapper function, we can eliminate that
There was a problem hiding this comment.
correct this is different from payment sheet, lets eliminate the wrapper function
25harsh
requested changes
Oct 18, 2024
| print("-- exit widget") | ||
| DispatchQueue.main.async { | ||
| if let view = RNViewManager.sharedInstance.rootView { | ||
| let reactNativeVC: UIViewController? = view.reactViewController() |
There was a problem hiding this comment.
you are adding widget view to a UIViewController and then dismissing it, try to just remove the view
Shivam25092001
force-pushed
the
feat-pmm-widget-setup
branch
from
8770631
to
84b2494
Compare
25harsh
force-pushed
the
main
branch
5 times, most recently
from
aa6355e
to
b85f2bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADDED
REMOVED
SCREENSHOTS
RECORDING
Screen.Recording.2024-10-18.at.5.55.44.PM.mov