Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invite user api structure #1640

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kanikabansal-juspay
Copy link
Collaborator

@kanikabansal-juspay kanikabansal-juspay commented Oct 22, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Changed structure to use the new API response which is currently being called in the Invite page to show the role information.
Also View and Mange are changed to read and write according to the changed scope.

Screenshot 2024-10-25 at 10 43 28 AM

Motivation and Context

Better response structure.

How did you test it?

I tested it with the corresponding backend changes and it was working as expected.
Should merge it with the new-apis-permission backend changes.

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@kanikabansal-juspay kanikabansal-juspay added the S-in-progress Status: Implementation is underway label Oct 22, 2024
@kanikabansal-juspay kanikabansal-juspay self-assigned this Oct 22, 2024
@kanikabansal-juspay kanikabansal-juspay requested a review from a team as a code owner October 22, 2024 12:41
Copy link

Review changes with SemanticDiff.

@kanikabansal-juspay kanikabansal-juspay linked an issue Oct 22, 2024 that may be closed by this pull request
11 tasks
Copy link
Contributor

@Riddhiagrawal001 Riddhiagrawal001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Change variable names to something what that variable holds
  • Remove logs
  • Also change type names to something what that type holds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-in-progress Status: Implementation is underway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CHORE] Permissions Change and user management change
2 participants