fix(ui): Specify a non-versioned FontAwesome #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickHastings
force-pushed
the
fix-fontawesome
branch
from
fbdec94
to
cb9abe9
Compare
NickHastings
changed the title
|
Thanks @NickHastings the commit does not respect the convention. |
NickHastings
force-pushed
the
fix-fontawesome
branch
2 times, most recently
from
29fd018
to
b260e94
Compare
The current css specifies "FontAwesome 5 Free Solid", for .drawing and .text-button. This results in the button icons/fonts not rendering correctly on systems that do not have that exact version of FontAwesome. This change adds the more generic "FontAwesome" as an option allowing the icons/fonts to be rendered correctly on these systems.
NickHastings
force-pushed
the
fix-fontawesome
branch
from
b260e94
to
1f6ff42
Compare
|
I removed all capitalization from the first line in the commit log. Is that what is required? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current css specifies "FontAwesome 5 Free Solid", for .drawing and .text-button. This results in the button icons/fonts not rendering correctly on systems that do not have that exact version of FontAwesome. This change allows the icons/fonts to be rendered correctly on these systems.
This should resolve issues like #91 without users having to modify their local gtk css configurations.
BTW, I'm really liking swappy: IMO it has just the right balance of ease of use vs features. Thanks for the great software.