Define a MSRV, use that toolchain by default. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR defines a Minimum Supported Rust Version. It specifies that toolchain in `rust-toolchain`, so `rustup` will use that toolchain by default. The `test-stable` make action is removed, as it is now redundant. We still need the nightly toolchain for Miri. Instead of specifying the nightly toolchain version via the command line, I created a new `nightly/rust-toolchain.toml` file that specifies the toolchain. The benefit is this makes `rustup` automatically install the nightly toolchain *including Miri*. This should stop the toil we currently have where every time the Rust toolchain is updated, everyone using `make test` has to manually install new toolchains and Miri. The downside is it's kinda ugly. I set the MSRV to 1.70 so this doesn't conflict with tock#498. I will send another PR that adds `rust-version.workspace = true` to all the `Cargo.toml` files in this repository; I didn't want to clutter this PR with those changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines a Minimum Supported Rust Version. It specifies that toolchain in
rust-toolchain, sorustupwill use that toolchain by default. Thetest-stablemake action is removed, as it is now redundant.We still need the nightly toolchain for Miri. Instead of specifying the nightly toolchain version via the command line, I created a new
nightly/rust-toolchain.tomlfile that specifies the toolchain. The benefit is this makesrustupautomatically install the nightly toolchain including Miri. This should stop the toil we currently have where every time the Rust toolchain is updated, everyone usingmake testhas to manually install new toolchains and Miri. The downside is it's kinda ugly.I set the MSRV to 1.70 so this doesn't conflict with tock#498.
I will send another PR that adds
rust-version.workspace = trueto all theCargo.tomlfiles in this repository; I didn't want to clutter this PR with those changes.