-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #107 from jonisavo/fix/no-mandatory-logger-in-di
Drop requirement of Logger field from dependency injection codegen
- Loading branch information
Showing
13 changed files
with
155 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -76,4 +76,5 @@ crashlytics-build.properties | |
*.coverage | ||
/dist | ||
coveragereport/ | ||
TestResults/ | ||
TestResults/ | ||
.DS_Store |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using NUnit.Framework; | ||
using UIComponents.DependencyInjection; | ||
using UnityEngine; | ||
using UnityEngine.TestTools; | ||
|
||
namespace UIComponents.Tests.Roslyn | ||
{ | ||
public interface IMissingDependency {} | ||
|
||
public partial class ProvideErrorComponent : UIComponent | ||
{ | ||
[Provide] public ILogger MyLogger; | ||
[Provide] private IMissingDependency _dependency; | ||
} | ||
|
||
[Dependency(typeof(ILogger), provide: typeof(DebugLogger))] | ||
public partial class ProvideErrorClass : IDependencyConsumer | ||
{ | ||
[Provide] public ILogger MyLogger; | ||
[Provide] private IMissingDependency _dependency; | ||
private readonly DependencyInjector _dependencyInjector; | ||
|
||
public ProvideErrorClass() | ||
{ | ||
DiContext.Current.RegisterConsumer(this); | ||
_dependencyInjector = DiContext.Current.GetInjector(GetType()); | ||
UIC_PopulateProvideFields(); | ||
} | ||
|
||
private T Provide<T>() where T : class | ||
{ | ||
return _dependencyInjector.Provide<T>(); | ||
} | ||
} | ||
|
||
[TestFixture] | ||
public class ProvideErrorTests | ||
{ | ||
[Test] | ||
public void Error_Is_Printed_With_Logger() | ||
{ | ||
var component = new ProvideErrorComponent(); | ||
|
||
Assert.That(component.MyLogger, Is.InstanceOf<DebugLogger>()); | ||
LogAssert.Expect(LogType.Error, "[ProvideErrorComponent] Could not provide IMissingDependency to _dependency"); | ||
} | ||
|
||
[Test] | ||
public void Error_Is_Printed_With_DebugLog() | ||
{ | ||
var instance = new ProvideErrorClass(); | ||
|
||
Assert.That(instance.MyLogger, Is.InstanceOf<DebugLogger>()); | ||
LogAssert.Expect(LogType.Error, "Could not provide IMissingDependency to _dependency"); | ||
} | ||
} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Binary file modified
BIN
+512 Bytes
(100%)
Assets/UIComponents/Roslyn/UIComponents.Roslyn.Common.dll
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
+1.5 KB
(100%)
Assets/UIComponents/Roslyn/UIComponents.Roslyn.Generation.dll
Binary file not shown.
Binary file modified
BIN
+264 Bytes
(100%)
Assets/UIComponents/Roslyn/UIComponents.Roslyn.Generation.pdb
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters