test(roslyn): add unit tests for GetMemberType utility method (#114)

UIComponents.Roslyn/UIComponents.Roslyn.Analyzers/UIComponents.Roslyn.Analyzers/EmptyUxmlNameAnalyzer.cs

@@ -18,7 +18,7 @@ public sealed class EmptyUxmlNameAnalyzer : DiagnosticAnalyzer
  new LocalizableResourceString(nameof(Resources.UIC102_MessageFormat), Resources.ResourceManager, typeof(Resources));
  private static readonly LocalizableString Description =
  new LocalizableResourceString(nameof(Resources.UIC102_Description), Resources.ResourceManager, typeof(Resources));
- private static readonly string Category = "Layout";
+ private const string Category = "Layout";
 
  private static readonly DiagnosticDescriptor Rule =
  new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Error, isEnabledByDefault: true, description: Description);

UIComponents.Roslyn/UIComponents.Roslyn.Analyzers/UIComponents.Roslyn.Analyzers/EmptyUxmlTraitNameAnalyzer.cs

@@ -20,7 +20,7 @@ public sealed class EmptyUxmlTraitNameAnalyzer : DiagnosticAnalyzer
  new LocalizableResourceString(nameof(Resources.UIC103_MessageFormat), Resources.ResourceManager, typeof(Resources));
  private static readonly LocalizableString Description =
  new LocalizableResourceString(nameof(Resources.UIC103_Description), Resources.ResourceManager, typeof(Resources));
- private static readonly string Category = "Layout";
+ private const string Category = "Layout";
 
  private static readonly DiagnosticDescriptor Rule =
  new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Error, isEnabledByDefault: true, description: Description);

UIComponents.Roslyn/UIComponents.Roslyn.Analyzers/UIComponents.Roslyn.Analyzers/InvalidReadonlyMemberAnalyzer.cs

@@ -3,7 +3,6 @@
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
 using System.Collections.Immutable;
-using System.Linq;
 
 namespace UIComponents.Roslyn.Analyzers
 {
@@ -18,7 +17,7 @@ public sealed class InvalidReadonlyMemberAnalyzer : DiagnosticAnalyzer
  new LocalizableResourceString(nameof(Resources.UIC003_MessageFormat), Resources.ResourceManager, typeof(Resources));
  private static readonly LocalizableString Description =
  new LocalizableResourceString(nameof(Resources.UIC003_Description), Resources.ResourceManager, typeof(Resources));
- private static readonly string Category = "Core";
+ private const string Category = "Core";
 
  private static readonly DiagnosticDescriptor Rule =
  new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Error, isEnabledByDefault: true, description: Description);

UIComponents.Roslyn/UIComponents.Roslyn.Analyzers/UIComponents.Roslyn.Analyzers/UIComponentIdenticalStylesheetAnalyzer.cs

@@ -20,7 +20,7 @@ public sealed class UIComponentIdenticalStylesheetAnalyzer : DiagnosticAnalyzer
  new LocalizableResourceString(nameof(Resources.UIC101_MessageFormat), Resources.ResourceManager, typeof(Resources));
  private static readonly LocalizableString Description =
  new LocalizableResourceString(nameof(Resources.UIC101_Description), Resources.ResourceManager, typeof(Resources));
- private static readonly string Category = "Layout";
+ private const string Category = "Layout";
 
  private static readonly DiagnosticDescriptor Rule =
  new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Warning, isEnabledByDefault: true, description: Description);

UIComponents.Roslyn/UIComponents.Roslyn.Analyzers/UIComponents.Roslyn.Analyzers/UIComponentInternalMethodAnalyzer.cs

@@ -17,7 +17,7 @@ public sealed class UIComponentInternalMethodAnalyzer : DiagnosticAnalyzer
  new LocalizableResourceString(nameof(Resources.UIC002_MessageFormat), Resources.ResourceManager, typeof(Resources));
  private static readonly LocalizableString Description =
  new LocalizableResourceString(nameof(Resources.UIC002_Description), Resources.ResourceManager, typeof(Resources));
- private static readonly string Category = "Core";
+ private const string Category = "Core";
 
  private static readonly DiagnosticDescriptor Rule =
  new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Warning, isEnabledByDefault: true, description: Description);

UIComponents.Roslyn/UIComponents.Roslyn.Analyzers/UIComponents.Roslyn.Analyzers/UIComponentPartialAnalyzer.cs

@@ -3,7 +3,6 @@
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
 using System.Collections.Immutable;
-using System.Linq;
 using UIComponents.Roslyn.Common.Utilities;
 
 namespace UIComponents.Roslyn.Analyzers
@@ -19,7 +18,7 @@ public sealed class UIComponentPartialAnalyzer : DiagnosticAnalyzer
  new LocalizableResourceString(nameof(Resources.UIC001_MessageFormat), Resources.ResourceManager, typeof(Resources));
  private static readonly LocalizableString Description =
  new LocalizableResourceString(nameof(Resources.UIC001_Description), Resources.ResourceManager, typeof(Resources));
- private static readonly string Category = "Core";
+ private const string Category = "Core";
 
  private static readonly DiagnosticDescriptor Rule =
  new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Error, isEnabledByDefault: true, description: Description);

UIComponents.Roslyn/UIComponents.Roslyn.Common.Tests/RoslynUtilitiesTests.cs

@@ -185,6 +185,30 @@ public void Returns_Null_If_Member_Is_Not_Field_Or_Property()
 
  Assert.Null(memberType);
  }
+
+ [Fact]
+ public void Returns_FieldType_If_Member_Is_Field()
+ {
+ var fieldSymbol = Substitute.For<IFieldSymbol>();
+ var fieldType = Substitute.For<ITypeSymbol>();
+ fieldSymbol.Type.Returns(fieldType);
+
+ var memberType = RoslynUtilities.GetMemberType(fieldSymbol);
+
+ Assert.Equal(fieldType, memberType);
+ }
+
+ [Fact]
+ public void Returns_PropertyType_If_Member_Is_Property()
+ {
+ var propertySymbol = Substitute.For<IPropertySymbol>();
+ var propertyType = Substitute.For<ITypeSymbol>();
+ propertySymbol.Type.Returns(propertyType);
+
+ var memberType = RoslynUtilities.GetMemberType(propertySymbol);
+
+ Assert.Equal(propertyType, memberType);
+ }
  }
 
  public class GetTypeNameForNamespace

UIComponents.Roslyn/UIComponents.Roslyn.Common/Utilities/RoslynUtilities.cs

@@ -67,9 +67,9 @@ public static string GetTypeNameForNamespace(ITypeSymbol type, string nameSpace)
  var displayStringParts = displayString.Split('.');
  var namespaceParts = nameSpace.Split('.');
 
- // TODO: UGLY HACK. We don't want to shorten UIComponents types because doing so
+ // NOTE(joni): We don't want to shorten UIComponents types because doing so
  // may lead to compile errors, since the shortened type names may no longer
- // be valid. There should be some mechanism for generating using statements...
+ // be valid.
  if (nameSpace.StartsWith("UIComponents."))
  return displayString;
 
@@ -156,7 +156,7 @@ public static ITypeSymbol GetMemberType(ISymbol symbol)
  {
  if (symbol is IFieldSymbol fieldSymbol)
  return fieldSymbol.Type;
- else if (symbol is IPropertySymbol propertySymbol)
+ if (symbol is IPropertySymbol propertySymbol)
  return propertySymbol.Type;
 
  return null;