Fix regression in wasm connections behind NATs #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something in #54 broke connections between me and another peer (both of us behind NATs)
In this PR, we start sending null ice candidates, and add them on the receiving end. I'm not completely sure what the point of it is, but MDN examples do this so it's probably best if we do it too.
Sadly, this alone wasn't enough to fix the regression. Adding back the wait for ice gathering to complete, however, did fix the issue. So that means that on wasm, we now have some weird frankenstein of ice-trickle and non-trickle, but the regression is gone, and cross-play still seems to work. So it's still better than before, and I'm really anxious to get a fix for the regression merged, even if it's ugly and I don't really understand how it fixes it.
If anyone has ideas about what could be wrong with the trickle implementation, please let me know.
Fixes: #58
@rozgo