Merge pull request #445 from johanhelsing/clippy-signaling

ci: Run clippy with signaling feature enabled
johanhelsing · Mar 31, 2024 · 6001c1e · 6001c1e
2 parents 676a8a2 + 3ae4f6e
commit 6001c1e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/code.yml b/.github/workflows/code.yml
@@ -94,7 +94,7 @@ jobs:
         uses: Swatinem/rust-cache@v2.7.3
 
       - name: Run cargo clippy
-        run: cargo clippy --all-targets -- -D warnings
+        run: cargo clippy --features signaling --all-targets -- -D warnings
 
   lint-wasm:
     name: Clippy wasm

diff --git a/bevy_matchbox/src/signaling.rs b/bevy_matchbox/src/signaling.rs
@@ -64,6 +64,7 @@ use std::net::SocketAddr;
 /// }
 /// ```
 #[derive(Debug, Resource)]
+#[allow(dead_code)] // we take ownership of the task to not drop it
 pub struct MatchboxServer(Task<Result<(), Error>>);
 
 impl<Topology, Cb, S> From<SignalingServerBuilder<Topology, Cb, S>> for MatchboxServer
@@ -175,7 +176,7 @@ mod tests {
         )
         .into();
 
-        commands.insert_resource(MatchboxServer::from(server));
+        commands.insert_resource(server);
     }
 
     #[test]