Switch to ureq, and store headers/query in a resource #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s' in case a URL doesn't have a file extension
… instead, using threadpool for background loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the client to ureq using a AsyncComputeTaskPool to make requests non-blocking.
Its a optional follow-up to my PR:
requires bevy_tasks with
multi_threadedfeature, otherwise Task isn't awaitable. Not sure if this leads to duplication in the dependency tree, or if bevy_tasks from the main bevy version is re-used. Could probably work around this with come cfg() magic looking at which bevy_task feature is enabled.other than this it also moves headers/query-params into a Resource which shares them with the AssetReaders using a
Arc<RwLock<>>. This allows the user to set/clear headers/query-params.I've tested all features locally.