Cherry pick fixes from develop to master #16
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BeWithin`/`Before` (fluentassertions#2312)
…implemented through an explicitly-implemented interface fixup! BeEquivalentTo will now find and can map subject properties that are implemented through an explicitly-implemented interface
…d to find members
To make it more visible that `GetMethod` is non-null inside `IsExplicitImplementation`
…pectation (fluentassertions#2358) * Handle non-generic `dictionary` subject when compared with a generic `dictionary` expectation * Add release notes Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com> --------- Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
…2329) * Pass `FormattingOptions` to inner `AssertionScope` * Add release notes * Simplify the `AssertionOptions.Formatting` test
* chore: capitalize true and false Display 'true' and 'false' as capitalized rathen than in lowercase so that both expected value and actual value uses the same casing. ---Before--- "Expected boolean to be false, but found True." ---After--- "Expected boolean to be False, but found True." * docs: update releases.md
This allows any potential BooleanFormatter to format them
* Add release notes for fluentassertions#2393 * Update releases.md Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com> --------- Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
…eption is `null` (fluentassertions#2398) * Improved the failure message for `ThrowExactly[Async]` * Add release notes Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com> --------- Co-authored-by: IT-VBFK <it@voecklabrucker-freikriche.at> Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
…hod)` (fluentassertions#2403) * Guard against assertion scope: `[Not]HaveExplicitProperty` * Guard against assertion scope: `[Not]HaveExplicitMethod` * Add release notes
… the caller identification logic
For properties and methods `PropertyInfoAssertions` and `MethodBaseAssertions` have assertions to exercise the `private`, `protected` and `private protected` cases in `GetCSharpAccessModifier(MethodBase)`. We don't have `FieldInfoAssertions` so we only exercise the access modifiers on fields through `WhichGetterHas`/`WhichSetterHas`. Since `GetFieldsFromHierarchy` excludes `private`, `protected` and `private protected` fields those three cases cannot currently be hit through the public API.
…ons#2448) * Fix "Possible 'null' assignment to non-nullable entity" * Add null check only when not NET6 or greater
…sertions#2511) * Fix issue when an empty ArraySegmnet is a member of a class. With latest, it crashes when trying to access the array members. * Fix PR comments. * Fix Qodana complaints * Update releases.md * Address review comments --------- Co-authored-by: Shahar Prish <shaharp@microsoft.com>
…2489) * Correct null handling when having a nullable struct propertywith a custom comparer. fluentassertions#2480 * Release notes added * typo corrected * Removed the check for only value types and added the null check for the expectation. Also added more tests for all cases. * typo corrected * Warnings solved * Added a comment for the changed code * Comment cleaned * Update docs/_pages/releases.md Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com> * Typo corrected Co-authored-by: ITaluone <44049228+ITaluone@users.noreply.github.com> * Corrected Qodana issues * cleanups --------- Co-authored-by: Martin Demberger <martin.demberger@root-nine.de> Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com> Co-authored-by: ITaluone <44049228+ITaluone@users.noreply.github.com> Co-authored-by: Jonas Nyrup <jnyrup@gmail.com>
…entassertions#2530) * BeEmpty() materializes IEnumerable<T> only once, even on failure - Make BeEmpty() materialize only the first item, as no further processing is needed for validation - The error message now mentions "but found at least 1 item" and outputs the said item * Tweak error message & fix tests * Make similar changes for BeNullOrEmpty * Add test, as per request
…assertions#2607) Also fixed an inconsistency in which one overload of the assertion scope constructor would not actually affect AssertionScope.Current.
The local function avoid allocating a lambda when not used. For more details, see: dotnet/roslyn#20777
…e types (fluentassertions#2648) Handle custom comparer for nullable fields (fluentassertions#2595)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick fixes from develop to master
Currently excluding fluentassertions#2569
I added these four commits to make it compilable.
I can also make it more digestible by excluding 493f155 and a1b9e7d which I've instead done in #17
IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome