Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out ghost cells during learning and when generating completions #329

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

jlewi
Copy link
Owner

@jlewi jlewi commented Oct 26, 2024

Filter out ghost cells

We don't want to include ghost cells as input when generating completions or as part of the doc that gets indexed when learning. This can lead to erroneous signal because the ghost cells could be wrong if they haven't been accepted (#174).
The bug is described in #174 (comment)

The fix is as follows

  • Preserve metadata when converting from Runme proto to Foyle proto
  • Metadata contains the _ghostCell key to indicate its a ghost cell
  • Use a preprocessing function to filter out the ghost cells

We put the logic for filtering out ghostCells into a reusable preprocessing function so that we can use the logic consistently.

Fix #174

Copy link

netlify bot commented Oct 26, 2024

Deploy Preview for foyle canceled.

Name Link
🔨 Latest commit e5b9767
🔍 Latest deploy log https://app.netlify.com/sites/foyle/deploys/6722650085245d0008c70720

@jlewi jlewi marked this pull request as ready for review October 30, 2024 17:02
@jlewi jlewi merged commit c5ee9b7 into main Oct 30, 2024
5 checks passed
@jlewi jlewi deleted the jlewi/filterghost branch October 30, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ghost cells shouldn't be included when generating completions
1 participant