Filter out ghost cells during learning and when generating completions #329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out ghost cells
We don't want to include ghost cells as input when generating completions or as part of the doc that gets indexed when learning. This can lead to erroneous signal because the ghost cells could be wrong if they haven't been accepted (#174).
The bug is described in #174 (comment)
The fix is as follows
We put the logic for filtering out ghostCells into a reusable preprocessing function so that we can use the logic consistently.
Fix #174