-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite selectors.py and add more tests #307
Conversation
@mischanix |
Profiling runs at #302 |
If you do a first commit that creates a dummy class EnumSelector, child of Selector, and move all the enum selectors to it, this will be easier to review :) |
7c79cbf
to
7d72a38
Compare
I went ahead and rewrote the history like you suggested. Btw, my initial version of this used the
I would prefer 3 since it's ultimately cleanest while not moving up requirements and potentially breaking people -- for example, Ubuntu trusty only goes up to 3.4 by default. |
8ba3ee1
to
35fdcd6
Compare
Split out AttrSelector -> AttrValue as requested |
35fdcd6
to
957cab6
Compare
Looks good to me. |
e9189a9
to
f52a234
Compare
Typing annotations: Why are most of them strings of objects? |
Overall code looks good, mostly just minor styling issues. Thanks. This looks like a really great rewrite. |
ec7148a
to
01acebd
Compare
Most of the typing annotations were changed once I pulled in the py3.5 commit. The remaining ones which are strings are forward references so type hints on a class's methods can refer to the class type itself (which hasn't been constructed yet). |
Landed your first 2 commits. Here's what's left to do:
|
01acebd
to
a370288
Compare
a370288
to
8b0ee23
Compare
Done |
8b0ee23
to
5316f18
Compare
Rewrite selectors completely: