Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding missing integration tests #87

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Adding missing integration tests #87

wants to merge 8 commits into from

Conversation

ebatsell
Copy link
Collaborator

@ebatsell ebatsell commented Sep 17, 2024 •
edited
Loading

  • Adds multi epoch tests and tests for certain functionality that was added/patched around steward launch

Adds some tests around:

  • validator lamport balances
  • Validator removal state method
    • Test for validators past num_pool_validators
  • Tests for validators to remove / instant removal / validators to add flow
  • Test epoch maintenance
    • General flow here, to make it easier to test in the future

@ebatsell ebatsell marked this pull request as ready for review September 30, 2024 20:04
coachchucksol
coachchucksol approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@coachchucksol coachchucksol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just fix up the linting and the tests!

ebatsell
ebatsell commented Oct 4, 2024
View reviewed changes
programs/steward/src/instructions/spl_passthrough.rs Show resolved Hide resolved
programs/steward/src/state/steward_state.rs
self.validators_for_immediate_removal
.set(validator_list_len, false)?;
.set(num_pool_validators_plus_added, false)?;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the changes here to properly shift indices even if validator_list_len < number of steward-tracked validators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coachchucksol coachchucksol coachchucksol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebatsell @coachchucksol