Add loadValidSyntaxesFromDir #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loadSyntaxesFromDir function is an all-or-nothing function: a single invalid file results in a error and *no* loaded syntaxes. This adds the loadValidSyntaxesFromDir, which is resilient against individual syntax file load failures. It returns a map of the failure messages, and the SyntaxMap that is created from all the successful parsing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
loadSyntaxesFromDirfunction is an all-or-nothing function: a single invalid file results in a error and no loaded syntaxes.This adds the
loadValidSyntaxesFromDirparallel function which is resilient against individual syntax file load failures. It returns a map of the failure messages, and theSyntaxMapthat is created from all the successful parsing.While the implementation is fairly trivial when implemented here, it makes use of local functions in this module and existing imports; duplicating that internal functionality and set of imports externally are not insignificant, thus the tradeoff against the expanded API surface is probably justified.