Fix building iotjs with ninja+MSVC #1957
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lygstate
force-pushed
the
ninja-fixes
branch
3 times, most recently
from
b18cb45
to
2d4df99
Compare
Testing MSVC generator and setup CONFIG_TYPE properly Add BUILD_BYPRODUCTS to ExternalProject_Add for building with Ninja IoT.js-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
lygstate
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix building iotjs with ninja+MSVC
Testing MSVC generator and setup CONFIG_TYPE properly
Add BUILD_BYPRODUCTS to ExternalProject_Add for building with Ninja
IoT.js-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com