Issue-332 : Added feature to check whether the deployment is on ECS or Lambda #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check to check whether the platform is ECS or Lambda since fileExistsBehavior is not required in ECS & Lambda but the code is setting this to DISALLOW by default
waseemahammed
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug Fix :
The code deploy step of Jenkins was set to use "DISALLOW" as default behavior of 'fileExistsBehavior'. This works with EC2 like deployment however, this option is not applicable for ECS or Lambda deployments using code deploy.
What is the current behavior? (You can also link to an open issue here)
The code deploy step of Jenkins was set to use "DISALLOW" as default behavior of 'fileExistsBehavior'. This works with EC2 like deployment however, this option is not applicable for ECS or Lambda deployments using code deploy.
What is the new behavior (if this is a feature change)?
The code will now check whether the deployment platform is ECS or Lambda, if so then will set fileExistsBehavior to null and for EC2 'DISALLOW' as default value.
Issue link here: [https://github.com//issues/332]
Does this PR introduce a breaking change? (What changes might users need to make in their setup due to this PR?)
No
Other information: