SET-718 Fix Zeus molecule issue #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sigh that's not the PR I meant to approve... @rpelisse could you review this before you merge it? |
rpelisse
requested changes
Feb 16, 2024
molecule/account/molecule.yml
Outdated
| pre_build_image: true | ||
| privileged: true | ||
| command: "/usr/sbin/init" | ||
| port_bindings: |
There was a problem hiding this comment.
Why do we need port-binding? I think we can remove those line, don't you think?
There was a problem hiding this comment.
You are right we are not testing any systemd-based service, we can remove it.
There was a problem hiding this comment.
@rpelisse modified it accordingly, Please review it.
RanabirChakraborty
force-pushed
the
SET-718
branch
from
f9632d9
to
2c0d984
Compare
rpelisse
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/SET-718
molecule issue discussion: ansible/molecule#4140