Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize tooling #151

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

jmalarcon
Copy link

@jmalarcon jmalarcon commented Nov 3, 2022

I've modernized the tooling used to build the tool since it was really outdated. That meant to upgrade to the latest versions of Gulp, Babel, Webpack and everything else, change some obsolete dev dependencies, change some gulp-plugins with tons of vulnerabilities, and rewriting the gulpfile.js file tasks, etc... Now it adds the .map file too.

Apart the build process adds the Notie version as a banner comment in the .js files inside dist (both minified and non-minified).

I've removed ESLint since it was really outdated, with vulnerabilities and nowadays VS Code and other IDEs do that for you.

I've updated the files in dist too to the newly generated ones. I've added the generation of map file for the script for debugging purposes.

This is the basis for being able to do new development in this great library. I plan to do a new pull request soon with full WCAG 2.1 accessibility support.

Hope you can merge the PR ad thanks for your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant