fix: don't add extra meta tag if it exists #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
commented
Jun 10, 2023
| @@ -76,7 +76,8 @@ class HtmlWebpackPlugin { | |||
| // Default metaOptions if no template is provided | |||
| if (!userOptions.template && options.templateContent === false && options.meta) { | |||
| const defaultMeta = { | |||
| // From https://developer.mozilla.org/en-US/docs/Mozilla/Mobile/Viewport_meta_tag | |||
| // TODO remove in the next major release | |||
There was a problem hiding this comment.
I think we should avoid to add any meta tags in the next major release, we can provide a good default HTML template, it should be inside template or we should fully parse HTML document and check if we already have duplications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1387