feat: injection of custom root element for react/vue/angular #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue had no activity for at least half a year. It's subject to automatic issue closing if there is no activity in the next 15 days. |
|
Bump. @jantimon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was previously using this plugin to inject a custom div root element into the generated HTML page.
However, that plugin has not been maintained for several years and no longer works with Webpack 5. I know many others have wished for root element support in the issues, so the time felt right to stick a PR in to implement that.
It is possible to supply a template to the arguments either by string literal, or by location of an HTML file, however that can be a little cumbersome as you then have to keep the HTML file in your repo, when really it doesn't actually need to be at all.
Reviews/comments/thoughts/suggestions welcome.