Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: injection of custom root element for react/vue/angular #1637

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

robertmain
Copy link

@robertmain robertmain commented Apr 17, 2021

I was previously using this plugin to inject a custom div root element into the generated HTML page.

However, that plugin has not been maintained for several years and no longer works with Webpack 5. I know many others have wished for root element support in the issues, so the time felt right to stick a PR in to implement that.

It is possible to supply a template to the arguments either by string literal, or by location of an HTML file, however that can be a little cumbersome as you then have to keep the HTML file in your repo, when really it doesn't actually need to be at all.

Reviews/comments/thoughts/suggestions welcome.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue had no activity for at least half a year. It's subject to automatic issue closing if there is no activity in the next 15 days.

@stale stale bot added the wontfix label Apr 16, 2022
@robertmain
Copy link
Author

Bump. @jantimon

@stale stale bot removed the wontfix label Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant