Repatch parser-standard to flambda-backend/main
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 2, 2024 15:24
Signed-off-by: Charlie Gunn <cgunn@janestreet.com>
Signed-off-by: Charlie Gunn <cgunn@janestreet.com>
freemagma
force-pushed
the
repatch-parser-standard
branch
from
6b0c9f8
to
d44c499
Compare
added 3 commits
August 2, 2024 15:35
Signed-off-by: Charlie Gunn <cgunn@janestreet.com>
Signed-off-by: Charlie Gunn <cgunn@janestreet.com>
Signed-off-by: Charlie Gunn <cgunn@janestreet.com>
ccasin
reviewed
Aug 5, 2024
There was a problem hiding this comment.
I took a look mainly at the tests, documentation changes, and Normalize_std_ast.ml, which look good except for some questions about the latter. I pushed a commit that extends the new test with versions of each functions that have lots of comments and attributes (since that is where we usually have trouble). This did turn up three bugs, but they all predate this PR so I just left comments about them and we don't need to fix them before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that modes and n-ary functions are in the parsetree in
flambda-backend, it's a good time to re-sync ocamlformat's parser. This required some changes toNormalize_std_ast.mlto deal with the new representation of functions in the parsetree.