Do not enforce let punning in let operators #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
dvulakh
force-pushed
the
dvulakh.do-not-pun-let-operators
branch
from
d19cb86
to
2783bf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not use operators like
let*internally, so we don't gain much by punning them. Meanwhile, enforcing that they are punned complicates the process of keeping internal copies of some external projects in sync with upstream.We restrict the let-punning added to the
janestreetprofile in #70 to let extension points, likelet%bind x in ().The tests reflect the new behavior.