-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove local rewrite flag and enable it by default #44
Remove local rewrite flag and enable it by default #44
Conversation
df7ba4d
to
0184a59
Compare
Removed the logic for erasing legacy local annotation syntax in ocamlformat/test/passing/tests/local_erased.ml Lines 1 to 5 in eceb638
|
21fd82a
to
4bb9282
Compare
eceb638
to
9f85b91
Compare
Signed-off-by: alanechang <alanechang@janestreet.com>
Signed-off-by: alanechang <alanechang@janestreet.com>
Signed-off-by: alanechang <alanechang@janestreet.com>
Signed-off-by: alanechang <alanechang@janestreet.com>
Signed-off-by: alanechang <alanechang@janestreet.com>
Signed-off-by: alanechang <alanechang@janestreet.com>
Signed-off-by: alanechang <alanechang@janestreet.com>
Signed-off-by: alanechang <alanechang@janestreet.com>
Signed-off-by: alanechang <alanechang@janestreet.com>
Signed-off-by: alanechang <alanechang@janestreet.com>
Signed-off-by: alanechang <alanechang@janestreet.com>
ffab059
to
f458255
Compare
Signed-off-by: alanechang <alanechang@janestreet.com>
Signed-off-by: alanechang <alanechang@janestreet.com>
@goldfirere Added one more commit to handle the pattern case differently. This fixes an issue caught by the CI tests. PR should be ready to merge if that commit looks good. |
Took a look at that last commit. Looks fine. Let's merge. |
This PR removes the
--rewrite-old-style-jane-street-local-annotations
flag and enables rewriting with the new syntax by default.A few consequences of this change are:
--erase-jane-syntax
now erases the old style local annotation too. See local-erased.ml.ref for differencesIn order for the AST equality checks to pass when we are modifying the tree deliberately, a newThe standard AST normalization is changed to convert old local syntax into the new syntax in order for the equality check to pass.ignore_local_annot_differences
option is added to ignore changes around local annotations in the standard AST. This option is set automatically when the legacy syntax is encountered. The alternative here is to convert old local syntax to the new or vice versa during normalization, which is non-trivial and will involve duplicating logic from jane syntax.