Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
parse new local syntax, but ignore when formatting
Signed-off-by: Charlie Gunn <cgunn@janestreet.com> Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Formatting. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Add tests. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Remove code to recognize ast pattern that no longer exists. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Support modes on arrow types. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Update normalize mapper to prevent bad sugaring. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Fix ast mapper to not drop modes and modalities in various places. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Support modes on value bindings. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Add support for modes in pattern constraints and expression constraints. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Support modalities on record declarations. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Support modalities on value declarations. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Fix test; in [let (pat @ mode) = exp], the mode is actually attached to the value binding, not the pattern. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Clean up some crs Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Add tests for comments. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Fixup. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Add tests related to comments, and actually format comments. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Fix moving comment in record fields. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Revert changes which transformed old mode syntax to new mode syntax. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Add tests and make minor changes for formatting with line breaks. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Test in conjunction with old syntax. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Minor test updates. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Resolve some crs Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> resolve a cr Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Resolve cr related to comments moving around global_ Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Resolve cr. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Resolve some crs. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Add some more broken tests. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> fixup new test. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Fix formatting of tuple patterns where els have modes. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> More pattern tests. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> More pattern tests. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Remove cr related to future feature. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Resolve cr for adding more pattern tests Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Add labeled tuple pattern tests. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Fix labeled tuple pattern punning with modes. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Add more expression tests. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Fix invalid punning of labeled tuple expressions with modes. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Add more let binding tests. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Reorganize tests into modules for easier visual navigation. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Add additional sugar test. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Update comment in test. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Add tests for attributes. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Fix issue with comments after [@] and [@@]. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Miscellaneous fixes during review. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Add missing tests. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Fix modes on let-bound tuple patterns. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Fix parens around aliased patterns with modes Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Fix tuple patterns with local exprs. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com> Fix let class expressions. Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com>
- Loading branch information