Skip to content

Commit

Permalink
fix(artifactory): ignore extensions without a manifest
Browse files Browse the repository at this point in the history
This ignores extensions where the manifest download from
artifactory failed instead of crashing the process with a
segfault.

It fixes coder#68
  • Loading branch information
janLo committed Oct 30, 2024
1 parent 2da8330 commit 693c7af
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion storage/artifactory.go
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ func (s *Artifactory) WalkExtensions(ctx context.Context, fn func(manifest *VSIX
return err
} else if err != nil {
id := ExtensionID(ext.publisher, ext.name, ext.versions[0].Version)
s.logger.Error(ctx, "Unable to read extension manifest", slog.Error(err),
s.logger.Error(ctx, "Unable to read extension manifest; extension will be ignored", slog.Error(err),
slog.F("id", id),
slog.F("targetPlatform", ext.versions[0].TargetPlatform))
} else {
Expand All @@ -405,6 +405,9 @@ func (s *Artifactory) WalkExtensions(ctx context.Context, fn func(manifest *VSIX
return err
}
for _, ext := range extensions {
if ext.manifest == nil {
continue
}
if err = fn(ext.manifest, ext.versions); err != nil {
return err
}
Expand Down

0 comments on commit 693c7af

Please sign in to comment.