[Draft] Override default settings through url parameters #174 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for svgomg ready! 🔨 Explore the source changes: 8588932 🔍 Inspect the deploy log: https://app.netlify.com/sites/svgomg/deploys/618d2a81ae336a0007f557a2 😎 Browse the preview: https://deploy-preview-209--svgomg.netlify.app |
|
@Mojeer0 can you rebase and make sure tests are green? |
jeromebon
force-pushed
the
feat-url-settings
branch
from
a90dc7e
to
cb9ccc9
Compare
XhmikosR
reviewed
Oct 28, 2021
src/js/page/main-controller.js
Outdated
| @@ -250,7 +250,12 @@ export default class MainController { | |||
| } | |||
|
|
|||
| async _loadSettings() { | |||
| const settings = await storage.get('settings'); | |||
| let settings = await storage.get('settings'); | |||
| settings = Object.assign( | |||
There was a problem hiding this comment.
This can be a spread instead
|
This doesn't seem to work when Service Workers are disabled. |
The parent element already has the title set. Also, add `aria-hidden="true"` in the SVGs.
jeromebon
force-pushed
the
feat-url-settings
branch
from
430863b
to
8588932
Compare
jeromebon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allow to override svgomg default settings through url parameters. #174
It's usefull when you want to share svomg to coworkers without asking them to check/uncheck some options.
Seach parameters names are the same as the input name attribute, which also are the same as svgo options name. For example to set "Prefer viewBox to width/height" by default one would use https://jakearchibald.github.io/svgomg/?removeDimensions=true
Options from the url parameters are taken into account at 2 moments:
Fixes #174