-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jaeger-v2] Refactor ElasticSearch/OpenSearch Storage Configurations #6060
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6060 +/- ##
==========================================
- Coverage 96.92% 96.91% -0.01%
==========================================
Files 349 349
Lines 16598 16646 +48
==========================================
+ Hits 16087 16133 +46
- Misses 328 329 +1
- Partials 183 184 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
d0ed3f2
to
4663d80
Compare
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@yurishkuro regarding #5790 (comment), are you referring to https://github.com/jaegertracing/jaeger/blob/main/plugin/storage/es/factory.go#L196-L210? |
yes |
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
…aegertracing#6060) ## Which problem is this PR solving? - Part of jaegertracing#6059 ## Description of the changes - Continuation of jaegertracing#5790 - Refactors the configurations for ElasticSearch and OpenSearch to simplify the configuration by having more logical groupings ## How was this change tested? - Unit Tests and E2E Integration Tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Jared Tan <jian.tan@daocloud.io> Co-authored-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
…aegertracing#6060) ## Which problem is this PR solving? - Part of jaegertracing#6059 ## Description of the changes - Continuation of jaegertracing#5790 - Refactors the configurations for ElasticSearch and OpenSearch to simplify the configuration by having more logical groupings ## How was this change tested? - Unit Tests and E2E Integration Tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Jared Tan <jian.tan@daocloud.io> Co-authored-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test