Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use named import for globby #609

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juliangilbey
Copy link

Summary

When building webfont, I received the following warning/error:

(!) Plugin typescript: @rollup/plugin-typescript TS2349: This expression is not callable.
  Type 'typeof import("/usr/share/nodejs/globby/index")' has no call signatures.
src/standalone/index.ts: (121:28)

121   const foundFiles = await globby([].concat(options.files));
                               ~~~~~~

Proposed changes

This PR, written by Israel Galadima, fixes this.


How to test

Describe the tests that you ran to verify your changes:

  1. Run the build.
  2. Notice that this warning/error message no longer appears.

Test configuration

  • Node.js version (if applicable): 18.12.1

Checklist

  • I have added corresponding labels to this PR (like bug, enhancement...); it's a bug, but I don't know how to add labels
  • My commits follow the Conventional Commits 1.0 Guidelines;
  • My code follows the style guidelines of this project;
  • I have performed a self-review of my own code;
  • I have mapped technical debts found on my changes; N/A
  • I have made changes to the documentation (if applicable); N/A
  • My changes generate no new warnings or errors;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant