Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix casting of slices of services #340

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

rtay1188
Copy link
Collaborator

@rtay1188 rtay1188 commented Sep 10, 2024

Checklist

🚨 Please review this repository's contribution guidelines.

  • I've read and agree to the project's contribution guidelines.
  • I'm requesting to pull a topic/feature/bugfix branch.
  • I checked that my code additions will pass code linting checks and unit tests.
  • I updated unit and integration tests (if applicable).
  • I'm ready to notify the team of this contribution.

Description

Previously, we were attempting to cast []*v1.Service to metav1.Object. This is because the cached services are stored as slices, as each identity could have more than one service. Instead, we check the service that we got the event for against each of the services in the slice to pick the right one in the cache to cast to metav1.Object.

Thank you!

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.71%. Comparing base (14b4735) to head (afbe175).

Files with missing lines Patch % Lines
admiral/pkg/controller/admiral/controller.go 87.50% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
+ Coverage   71.65%   71.71%   +0.05%     
==========================================
  Files          66       66              
  Lines        9212     9226      +14     
==========================================
+ Hits         6601     6616      +15     
+ Misses       2253     2252       -1     
  Partials      358      358              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Ryan Tay added 3 commits September 10, 2024 14:25
Signed-off-by: Ryan Tay <ryan_tay@intuit.com>
Signed-off-by: Ryan Tay <ryan_tay@intuit.com>
Signed-off-by: Ryan Tay <ryan_tay@intuit.com>
@rtay1188 rtay1188 merged commit a383b2c into istio-ecosystem:master Sep 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants