Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MESH-5405-Create Additional SE #335

Closed

Conversation

Punakshi
Copy link
Collaborator

@Punakshi Punakshi commented Sep 1, 2024

Checklist

🚨 Please review this repository's contribution guidelines.

  • I've read and agree to the project's contribution guidelines.
  • I'm requesting to pull a topic/feature/bugfix branch.
  • I checked that my code additions will pass code linting checks and unit tests.
  • I updated unit and integration tests (if applicable).
  • I'm ready to notify the team of this contribution.

Description

What does this change do and why?

[Link to related ISSUE]

Thank you!

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 46.72489% with 122 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@2d8556d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
admiral/pkg/registry/testutils.go 7.20% 103 Missing ⚠️
admiral/pkg/clusters/serviceentry.go 21.42% 11 Missing ⚠️
admiral/pkg/clusters/configwriter.go 92.07% 4 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #335   +/-   ##
=========================================
  Coverage          ?   70.72%           
=========================================
  Files             ?       65           
  Lines             ?     9155           
  Branches          ?        0           
=========================================
  Hits              ?     6475           
  Misses            ?     2338           
  Partials          ?      342           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Punakshi Punakshi closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants