Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MESH-5405-IdentityConfig-Struct-Edit #334

Conversation

Punakshi
Copy link
Collaborator

@Punakshi Punakshi commented Aug 30, 2024

Checklist

🚨 Please review this repository's contribution guidelines.

  • I've read and agree to the project's contribution guidelines.
  • I'm requesting to pull a topic/feature/bugfix branch.
  • I checked that my code additions will pass code linting checks and unit tests.
  • I updated unit and integration tests (if applicable).
  • I'm ready to notify the team of this contribution.

Description

What does this change do and why?

[Link to related ISSUE]

Thank you!

@Punakshi Punakshi requested review from rtay1188 and vinay-g and removed request for rtay1188 August 30, 2024 02:04
@Punakshi Punakshi changed the title MESH-MESH-5405-IdentityConfig-Struct-Edit MESH-5405-IdentityConfig-Struct-Edit Aug 30, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.00000% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@2d8556d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
admiral/pkg/clusters/serviceentry.go 21.42% 11 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #334   +/-   ##
=========================================
  Coverage          ?   71.40%           
=========================================
  Files             ?       65           
  Lines             ?     9002           
  Branches          ?        0           
=========================================
  Hits              ?     6428           
  Misses            ?     2234           
  Partials          ?      340           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Punakshi Punakshi closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants