Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MESH-5336] - Adding error cluster to logs to debug better #328

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

vinay-g
Copy link
Collaborator

@vinay-g vinay-g commented Aug 20, 2024

Checklist

🚨 Please review this repository's contribution guidelines.

  • I've read and agree to the project's contribution guidelines.
  • I'm requesting to pull a topic/feature/bugfix branch.
  • I checked that my code additions will pass code linting checks and unit tests.
  • I updated unit and integration tests (if applicable).
  • I'm ready to notify the team of this contribution.

Description

What does this change do and why?

[Link to related ISSUE]

Thank you!

Signed-off-by: vinay-g <vinayg99@gmail.com>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.72%. Comparing base (3e19061) to head (780db43).

Files Patch % Lines
admiral/pkg/clusters/serviceentry.go 0.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   71.74%   71.72%   -0.02%     
==========================================
  Files          65       65              
  Lines        8723     8725       +2     
==========================================
  Hits         6258     6258              
- Misses       2147     2148       +1     
- Partials      318      319       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinay-g vinay-g merged commit 84e9f9d into master Aug 20, 2024
3 checks passed
@vinay-g vinay-g deleted the MESH-5336 branch August 20, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants